This project is read-only.
1
Vote

Pull Req: FXCop Rule for CA2241

description

I don't how to do pull request from a differen codeplex project to Roslyn.
Project: String.Format Diagnostic (Roslyn)

It is a Diagnostic to check the text argument of a formatstring, to see if it valid.

CA2241: Provide correct arguments to formatting methods

comments

AlexTurnMSFT wrote Jul 23, 2014 at 1:07 AM

This is great to see! The procedure would be for you to take a snap of your code here and port it to fit in as a part of your fork of the Roslyn solution. Then you can submit that as a normal pull request.

Note that we're focusing on the engine moreso than specific rules right now, and so we're likely to consider such pull requests down the line (maybe in a few months). We'll keep this active until then to track the request.

AdamSpeight2008 wrote Jul 24, 2014 at 12:49 AM

I've created a new fork and integrated in to that. The other fork would cause loads of problems.
[Pull Request](https://roslyn.codeplex.com/SourceControl/network/forks/AdamSpeight2008/RoslynSFD/contribution/7176

AlexTurnMSFT wrote Sep 11, 2014 at 2:06 AM

Thanks for cleaning up the pull request here!

We're holding off on our work on diagnostic content (including pull requests) for the moment, as we focus on building out the diagnostic infrastructure, and getting our APIs ready. We'll dig in to your pull request once that's complete.